-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure test failures #231
Ensure test failures #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me but would like another review to make sure I’m not missing anything
I did some more research and testing with |
The |
@reconbot any reason why we wouldn’t adapt the same convention for all tests that use |
We should do just that - I only addressed the unit tests in this PR |
we only use It’s been open for a week now, I’d say we go ahead and merge it in if you are ready from your side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks.
The double expect and the return instead of throw wasn't working.